pull icon indicating copy to clipboard operation
pull copied to clipboard

Published 20 hours ago • verified publisher icon wei

feat: comment when auto merge/hardreset fails

Open wei opened this issue 4 years ago • 6 comments

Currently GitHub returns an error when Pull tries to merge into a protected branch. The PR will just stay open ready to be manually merged.

An improvement will be commenting on the PR when this happens.

wei avatar Aug 22 '20 13:08 wei

One reason PRs fail to be merged automatically is due to changes in .github/workflows files (GitHub Apps do not have write access to it)

wei avatar Sep 15 '20 17:09 wei

😀

jefferycline1 avatar Jan 04 '22 04:01 jefferycline1

@wei Assign it to me.

joshiayush avatar Jan 16 '22 04:01 joshiayush

hi @wei :wave:

are there other scenarios in which a pull doesn't auto-merge? i do not have branch protection enabled and this PR from yesterday (first one since I added pull.yml) is still open 🤔

ddelange avatar Sep 30 '22 04:09 ddelange

oh and now (9hrs after opening) the PR merges. maybe I spoke too soon. is that a normal time frame?

ddelange avatar Sep 30 '22 05:09 ddelange

Hiiii @ddelange thanks for using Pull. Due to the large amount of repos using pull and the unpredictability timeframe for GitHub to mark a PR as mergeable, this timeframe is not abnormal. This issue we are on is for a new feature unrelated to your inquiry. Please open a new issue or comment on a more relevant issue if you have further questions!

wei avatar Sep 30 '22 05:09 wei