google
FIX #3659 -- Use `__cpp_lib_char8_t` macro to support `UTF-8` code units
Since __cpp_char8_t does not guarantee to represent UTF-8 code units we should use __cpp_lib_char8_t macro instead to support UTF-8 code units otherwise use of __cpp_char8_t will lead to build failure.
Fixes https://github.com/google/googletest/issues/3659
For reference see.
Signed-off-by: Ayush Joshi [email protected]
@derekmauro Sorry my previous commit https://github.com/google/googletest/pull/3703 was directly on the main branch of my fork and I did not realise it 😅, yes I know I sound stupid.
@MikeChan-HK Like my previous PR https://github.com/google/googletest/pull/3703 this one again didn't pass Windows, please guide me I'm not familiar with gmock yet. The reason why I asked you is because you approved PR https://github.com/google/googletest/pull/3703 regardless of the failing action.
@dinord Hey is this PR even visible from your end or I'm stuck in some kind of parallel earth? I'm not sure but in case you see this don't forget to drop a review from your side down here.
This is failing on windows, and the reason seems to be that it's inserting \r before each \n, causing the output to be different from the golden file. Is this change fit for Windows?
This is failing on windows, and the reason seems to be that it's inserting
\rbefore each\n, causing the output to be different from the golden file. Is this change fit for Windows?
Yes, that's how Windows define a line feed. What should be done in this case?
