Joren Broekema

Results 119 comments of Joren Broekema

I very much appreciate the story you wrote up helping us understand why these things happened, and shining a light on some issues of open source. Thanks for your work,...

@kaufmann42 @Ostefanini @dev-whiteflag This is in line with conventional commits. If you did not release a v1 yet, you're still in alpha, which means it only bumps the patch number,...

I do agree that both in conventionalcommits and in semver, there is not much clarity about this, and that standard-version needs to document more clearly what it does with regards...

@rklec I prefer the current behavior for < v1.0.0: - minor bump for breaking changes - patch bump otherwise The reason being that I want to have a clear separation...

Hi, wondering if there is any traction on this.. since the last activity is 3 years ago. It is quite common to have a build-step/compile-step that creates a dist or...

Updated the other addFormElement override methods to be async and await super.addFormElement. One test still failing tho, couldn't figure it out in a timely manner

There was one failing test and I couldn't really figure out why it was failing, and I dont think anyone from the team reviewed this yet. I am not sure...

https://lion-web.netlify.app/docs/systems/form/features/ in this page something different is going wrong with the rich select in the umbrella form

Nice, thanks for creating the draft PR. I will look into it more closely but after a first scan I have a question: If we have these parts exposed, can...

With a fresh Typescript project scaffolded from `npm init @open-wc` and installing @lion/select, I don't get this problem and .modelValue works as intended, without lit-plugin errors or type errors. I...