Joren Broekema

Results 119 comments of Joren Broekema

Hey, good suggestion about making it searchable. I'm gonna spend some effort on revamping the docs, including the token structure section, I'll try to ensure that it's easy to find...

> Is that how it's supposed to work since [sd-transforms v0.15.0](https://github.com/tokens-studio/sd-transforms/blob/main/CHANGELOG.md#0150)? Pretty much, although the default tokens-studio transformGroup contains CSS specific transforms, which may give unexpected values if your target...

> @jorenbroekema I will try to create integration tests. Should I modify the existing [**integration**/android.test.js](https://github.com/amzn/style-dictionary/blob/v4/__integration__/android.test.js) or create another one? Probably a bit easier to create a separate one, if you...

> Ok. So I should write both the test and the expected snapshot, right? No, the first time you run the test with matchSnapshot call, it will initialize the snapshot...

>I couldn't find where the fontSizes (plural) type from Tokens Studio becomes a fontSize (singular) type in Style Dictionary. Hah well that's probably because that doesn't happen at all, I'm...

Could you try on the v4 branch perhaps to see if it's still a problem there? the offending code has been refactored a fair bit. See changelog for the breaking...

I think we can improve some of the logs indeed by at least telling the user the filePath of the offending token so it's easier to find. If the token...

True, we can use `token.path.join('.')`, PRs welcome! as of writing, use the v4 branch for now, if that branch no longer exists it means 4.0.0 has been released and the...

The reason wwhy your nav-gradient token is not being transformed is because it contains a token reference/alias (`{Palette.Black.Black 100}`. By default, transforms do not transform tokens with references in its...