Jordan Sissel

Results 273 comments of Jordan Sissel

I haven't tested yet, but the code looks good. I will try to make time to test this week .

> maybe an alternative fix would be to respect the shebang in the --after-install script? I like this alternate proposal, though I understand the implementation might be trickier. automatically choosing...

> Don't think I have time to do it that way right now No worries! We can make forward progress as time permits for anyone available to do the work...

I don't have a macOS Catalina machine to test with, so I'll have to test and hope I'm doing it right from Linux. On my linux machine, I faked it...

Hi! I also would like more types included in that list. Some small history here is that part of #1838 and #1839 added more detailed examples and dedicated documentation for...

``` % ls lib/fpm/package/*.rb | fex /-1.1 | sort | xargs -n1 sh -c 'if [ -f "docs/packages/$1.rst" ] ; then echo "✅ Found d ocs for $1"; else echo...

fpm v1.14.2 released that includes an improvement for this issue. https://fpm.readthedocs.io/en/stable/packaging-types.html Example screenshot from the sidebar: ![image](https://user-images.githubusercontent.com/131818/160998679-0b710241-6c6d-401b-b685-5e511465f59e.png)

I like this idea. This might cause some confusion with the existing `--config-files` flag, though. Specifically, having `--config` mean "load this file as command line flags for fpm" and `--config-files...

I found a way to possibly make this work as a flag in fpm: https://github.com/jordansissel/fpm/issues/1902#issuecomment-1129671424 No promises on when/if it'll get implemented, but the prototype looks promising to me :)

The tests aren’t in great shape these days, and there’s a few tests that always fail. For this PR, don’t worry about them. On Sun, Mar 28, 2021 at 2:31...