Jordan Sissel

Results 273 comments of Jordan Sissel

For the Inline::CPP hang (which takes several minutes before hanging as it installs a dozen or so Perl modules), I can confirm that `master` hangs and the `perl` subprocess is...

@wbraswell for tonight at least, I'm going to try and go through as many of the referenced issues as i can and figure out a solution (plus review the relevant...

@wbraswell do you know of any way to speed this up? Each `fpm` invocation is installing dependencies (Module::Build, etc) and it takes 2-3 minutes for each attempt before I can...

@wbraswell figured out the performance as I remembered cpan runs the test suite by default. `--no-cpan-test` makes it fast. I found that `< /dev/null` on fpm will make this work:...

This appears to fix Inline::CPP by closing `stdin` so that Inline::CPP's Makefile.PL will get nothing when reading (instead of blocking for reads): ```diff diff --git a/lib/fpm/util.rb b/lib/fpm/util.rb index 6ebfde2..117353c 100644...

The patch in https://github.com/jordansissel/fpm/pull/1528#issuecomment-466620965 appears to resolve #1519 and does not add any test failures (master currently has 13 failing tests on my workstation, and adding this patch keeps it...

For #1518, if I take just one line, I think it fixes it: https://github.com/jordansissel/fpm/pull/1518/files#diff-2533a90976db66b6aaa59e0763508b96R317 ```diff % git diff diff --git a/lib/fpm/package/cpan.rb b/lib/fpm/package/cpan.rb index cbb786f..64eec8d 100644 --- a/lib/fpm/package/cpan.rb +++ b/lib/fpm/package/cpan.rb @@...

I took the above diff and committed it to a branch as @wbraswell 9d774843aebd565abea36357951ae31e10edb0bf Two issues down. Three to go? ;)

@wbraswell The stdin one was kind of a fun bug! Thank you for working on all of this. https://github.com/jordansissel/fpm/pull/1610 should fix many of these things. I excluded the SRPM because...

One related (I think) test failed in Travis: ``` 4) FPM::Package::Deb#output when read with dpkg should have the correct dependency list Failure/Error: insist { dpkg_field("Depends") } == "something (>> 10),...