Jordan Rome

Results 346 comments of Jordan Rome

> Maybe I write too much c++/rust. In both languages you end up having a top level namespace w/ same name as project. But do you find yourself writing the...

@viktormalik @danobi - One last look before I merge?

@simpleton Sadly, our docs are a bit out of date. I think we're right now looking at a min version of 5.15 as our support backstop - though we're still...

Ah yes. Thanks for the follow up.

I split this into 3 commits so hopefully it's a bit easier to review now.

> I was able to trigger a segfault Ah good catch. Fixed

Implemented the changes discussed offline during office hours: - [x] require that named parameters always come after a double dash (for all cases) - [x] require an `=` after named...

> Mind moving some of the refactoring parts to separate commits? If you really feel strongly, I will try to tease it apart but at this point it feels like...

Thanks for the review @amscanne and @viktormalik ! I think we landed on something that fits nicely into our language/tool goals.

- https://github.com/bpftrace/bpftrace/pull/4156