Jordan Rome

Results 346 comments of Jordan Rome

@viktormalik with the sharp eyes 👀

@fbs Any objections to merging?

Sorry, saw this before I asked for tests on the PR :) Here are the unit tests: https://github.com/bpftrace/bpftrace/blob/master/tests/semantic_analyser.cpp#L3167 And the runtime tests: https://github.com/bpftrace/bpftrace/blob/d93aae09689ccb8fcbbf230f8d7b3831cb12b881/tests/runtime/call#L469

Sounds reasonable to me. I also don't much care for the alternative solutions. For adding multiple configs, what about comma separated (feels more similar to the colon separated probe syntax)...

> There's also the third option of using semicolons to match the config block. I like this option and even think it looks ok when they all have their own...

> As an extension. Should attributes also be considered on maps? @fbs I like this suggestion and I think I would prefer something like map attributes for specifying the map...

@ajor - Should we close this RFC in favor of the UFCS one? Seems like folks were pretty split on adding "methods" at least in this form.

Switching to just use `fmt` seems like simpler/easier solution to fixing string processing issues.