Jordan Rome

Results 346 comments of Jordan Rome

I agree that auto printing of maps at the end is blah AND that maybe too many people might rely on this default behavior to change it (at least without...

@jjyr Is this repo still maintained?

@jjyr No worries! For fedora packages based on Rust crates (e.g. https://src.fedoraproject.org/rpms/rust-scx_rustland) that don't require the rust tool chain to just run as binaries/executables.

Do we know of any use cases in C, or, more specifically BPF C code, of using enums in arithmetic operations? Also if we make enum it's own type that...

> Can LOG(FATAL) throw a custom exception rather than runtime_error? Having a central choke point is nice. Also it's a bit more consistent to read/write. I think creating a custom...

Additionally, the way `log.cpp` works now we can't catch errors thrown in the destructor e.g. ``` [[noreturn]] LogStreamBug::~LogStreamBug() { throw std::runtime_error(buf_.str()); //sink_.take_input(type_, loc_, out_, internal_location() + buf_.str()); //abort(); } ```

Confirmed that `other.positional ustack` works on my Arm VM with this change.

I'll update the changelog and adoc once the code is approved.

Note: Also going to add a codegen test for this Note: NM, I realized this is problematic because of the dynamic look up of the number of processors on the...

@danobi @ajor I think maybe we should ship this as is. It won't work for AOT because to do this properly by dynamically passing in the number of cpus from...