Jordan Rome

Results 346 comments of Jordan Rome

@c-dante I agree about not being able to change a stream's value or it's end stream's value once a stream has ended. In terms of error throwing, I'm not sure...

> There might be space for an argument of hooking up ended streams just push their last value and end immediately -- so you get 1 fire and that's it....

@ericgj When I first saw this PR (yesterday) I got excited at the idea of having Eithers baked into flyd streams but I think I'm now in your camp in...

@jplikesbikes I think liftMonads as module would definitely be useful (not being part of the core lib seems risk free) :+1: As far as the promise overriding, part of me...

Ok, someone tell me what is wrong with this because I'm kinda loving it right now. Here is the modified flyd.map to return Eithers. ``` javascript var S = require('sanctuary');...

Agreed. This PR is awesome and thoughtful but should not be merged. > @jordalgo, your map function is cool. One problem is that it assumes that f would report errors...

The other fun conversion will be when you have situations like this ```js let myStub; beforeEach(() => { myStub = sinon.stub(someDependency, 'method'); }); it('should do something', () => { expect(myStub.calledOnce).toBe(false);...

@skovhus Ok cool. I may do some tinkering later this week. I'll push something up if I make any progress.

@skovhus I got started on a [branch](https://github.com/jordalgo/jest-codemods/commits/sinon). I'm running with the idea that the assertions have already been transformed to `jest.expect` (we can add a note that a test needs...

@skovhus I've made a little progress but have stalled a bit as I'm sort of considering whether Jest's spy/stub feature set is mature enough for this code mod. There are...