Jon Rohan

Results 33 issues of Jon Rohan

No reason really. I needed some way to email, found the npm `mailgun-js` package and used it. If someone wants to swap out for some easier service I'm 👍

### What are you trying to accomplish? The design interface guidelines for the SegmentedControl recently changed to have `role="list"` instead of `role="toolbar"` https://github.com/primer/design/pull/276#issuecomment-1205336999 This PR updates the classes to accommodate...

patch release

https://github.com/github/primer/issues/760 👋🏻 This is ready for review http://primer-view-components-preview-1225.eastus.azurecontainer.io/view-components/lookbook/inspect/primer/alpha/segmented_control/default ## SegmentedControl This PR adds a SegmentedControl component with status `:alpha` to the library. ### Arguments `SegmentedControl` | Name | Type |...

javascript
ruby
accessibility
blocked
waiting on review
css

It would be awesome if the "Source" tab was content editable, and would rebuild the preview above.

feature request

Follow up to https://github.com/primer/view_components/pull/1454 and https://github.com/primer/view_components/pull/1449 I realized the reason the machine was adding new images for the focus state on the autocomplete, was because the caret line was blinking....

skip changelog

# Input ```css .Button { position: relative; font-size: var(--primer-text-body-size-medium); font-weight: var(--base-text-weight-medium); cursor: pointer; user-select: none; background-color: transparent; border: var(--primer-borderWidth-thin) solid; border-color: transparent; border-radius: var(--primer-borderRadius-medium); color: var(--color-btn-text); transition: var(--primer-duration-fast) var(--primer-easing-easeInOut); transition-property:...

css

https://github.com/github/primer/issues/932 ## TODO - [x] Hide divider when it's the first item in the overflow menu. [Details](https://github.com/primer/view_components/pull/1339#issuecomment-1231248352) - [x] Look into alignment option [Details](https://github.com/primer/view_components/pull/1339#issuecomment-1231279420) - [x] Do we need `ActionBar-item`...

javascript
ruby
css

When the site is building, it outputs hundreds of these warnings which makes it hard to see the logs. ``` When server rendering, you must wrap your application in an...

Follow up to https://github.com/primer/view_components/pull/2664 This gives the playwright screenshots ownership to @primer/design-reviewers My thoughts are that if the style changes then design should 👓

skip changeset