css icon indicating copy to clipboard operation
css copied to clipboard

Segmented control list

Open jonrohan opened this issue 3 years ago • 1 comments

What are you trying to accomplish?

The design interface guidelines for the SegmentedControl recently changed to have role="list" instead of role="toolbar" https://github.com/primer/design/pull/276#issuecomment-1205336999

This PR updates the classes to accommodate the new markup.

I'm also dropping the .SegmentedControl-button--selected to only rely on the aria-current attribute. This makes the JS behaviors simpler since there's no need to toggle a class.

Can these changes ship as is?

  • [x] Yes, this PR does not depend on additional changes. 🚢

jonrohan avatar Aug 09 '22 22:08 jonrohan

🦋 Changeset detected

Latest commit: 4ada6844d749f87dcc707472fc6d0b2bee2367db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 09 '22 22:08 changeset-bot[bot]