view_components icon indicating copy to clipboard operation
view_components copied to clipboard

Fix snapshots tests to have less changes between commits

Open jonrohan opened this issue 2 years ago • 2 comments

Follow up to https://github.com/primer/view_components/pull/1454 and https://github.com/primer/view_components/pull/1449

I realized the reason the machine was adding new images for the focus state on the autocomplete, was because the caret line was blinking.

In this PR, I'm fixing that by injecting CSS to make the caret transparent. https://developer.mozilla.org/en-US/docs/Web/CSS/caret-color


Edit: I wonder if the best way to fix this is to scrap cuprite and go with playwrite. It would fix #1380 and align with a better solution for us.

jonrohan avatar Oct 05 '22 21:10 jonrohan

⚠️ No Changeset found

Latest commit: a385215156fa3a47893df2154cb6306d9074cc7e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 05 '22 21:10 changeset-bot[bot]

⚠️ Visual differences found

Our visual comparison tests found UI differences. Please review the differences by viewing the files changed tab to ensure that the changes were intentional.

Review visual differences

github-actions[bot] avatar Oct 05 '22 21:10 github-actions[bot]