Jonathan Jacobs

@neildhar Are there any other changes you'd like me to make, prior to moving on to reviewing the logic?

Thanks @neildhar! > 1. Add a new CMake option `HERMES_ENABLE_REGEXP_UNICODE_CHARACTER_CLASS` that we can use to turn the feature off. I ended up naming the option `HERMES_ENABLE_UNICODE_REGEXP_PROPERTY_ESCAPES`, I thought that aligned...

> 1. Could we update the unicode version in a separate commit from all of the changes to the script? This will be a useful sanity check that the changes...

@neildhar Just checking in if there's anything I still need to address, or can help with for this review.

> Everything looks good, apart from the minor comments, the only real ask is to add a file-level doc-comment in `genUnicodeTable.py` explaining what the steps are in producing the final...

A thought: Make the "on stored callback" (maybe this could be implemented with the same mechanism that `Request.notifyFinish` uses, for multiple "observers" if necessary) a plain Python function, this would...

Brief investigation indicates that the `inAttribute` flag is not propagated (either from [`WovenContext`](https://github.com/twisted/nevow/blob/aff713a6884a0ebf2214af5cfa3c1ea2d7d70669/nevow/_flat.py#L299) or from [nested `_flatten`](https://github.com/twisted/nevow/blob/aff713a6884a0ebf2214af5cfa3c1ea2d7d70669/nevow/_flat.py#L268) calls) in the render-directive case, preventing the `inAttribute` case of `escapedData` from being...

@wthie Sorry I should have mentioned that this was discovered and reproduced on Python 2.