Jonathan Jacobs
Jonathan Jacobs
@necolas Just want to say I appreciate you resolving this, and so thoroughly too, thank you!
I ran into an issue on web (RNW 0.18.9) where `react-native-popover-view` indicated it was waiting for a resize/orientation event to complete, but there wasn't anything like this happening and so...
> Bigger issue right now is styling. I managed to unravel the styling problems, at least the ones I was having, and I'm happy with the results, I ran into...
This doesn't seem to be fixed by #986. The [workarounds](https://github.com/lottie-react-native/lottie-react-native/issues/870#issuecomment-1114649517) don't work for me either.
Patches (created with `yarn patch`) also seem to trigger this issue quite reliably, adding a new patch will almost always cause yarn to fail with "YN0028: The lockfile would have...
(I'm including this outside of the PR description, in case that's used for automation purposes.) ## Looking for Feedback - I have modified `genUnicodeTable.py` to fetch from HTTP URLs instead...
> We would like to land this in Hermes, but since this is a lot of code, I hope you can bear through our review process, which can be very...
@tmikov I've restructured the original giant commit into several more digestible ones, I hope it helps make the review easier.
Thanks for the detailed feedback @neildhar, the godbolt output for those two snippets was really interesting! I've made the changes to `genUnicodeTable.py` and the utility functions to use the proposed...
Thank you again for the excellent feedback! Near the beginning of this change, having a single large pool did occur to me but I didn't know about dynamic reallocations, so...