Jon Atack

Fix -netinfo backward compat with getpeerinfo pre-v26

4

Commit fb5bfed26a564014b83ccfc96ff00b630930fc61 in #29058 will cause `-netinfo` to break when calling it on a node that is running pre-v26 bitcoind, as `getpeerinfo` doesn't yet return a "transport_protocol_type" field. Fix this...

Fix logging RPC and -debugexclude with 0/none values, add test coverage, improve docs

23

The logging RPC does not work as intended and as documented in its help when `0` or `none` are passed. Per the RPC logging help: ``` $ ./src/bitcoin-cli help logging...

doc: update -loglevel help to add `info` to the always logged levels

2

Commit ab34dc6012351e7b8aab871dd9d2b38ade1cd9b of #28318 was an incomplete version of [`118c756` (#25203)](https://github.com/bitcoin/bitcoin/pull/25203/commits/118c7567f62df2b882877590f232242d7c627a05) from the `Severity-based logging` parent PR. Add the missing text to update the `-loglevel` help doc. While here, make...

Do not log p2p bip61 reject messages, improve log, add tests

8

...per the IRC discussion around https://www.erisian.com.au/bitcoin-core-dev/log-2023-09-03.html#l-345. Rationale for not logging the bip61 reject messages (as unknown commands): - they are not unknown and were valid before v20; see ##15437 -...

net, refactor: extract Network and BIP155Network logic to node/network

13

This extracts the `Network` and `BIP155Network` logic to `node/network`. The code has been living between `netaddress` and `netbase` and some compilation units include these large files when they only need...

test: update tool_wallet coverage for unexpected writes to wallet

10

1. Create file permission utilities in the functional test framework based on #27850 and #15687. 2. PR #15687 added test coverage in `test/functional/tool_wallet.py` to reproduce unexpected writes to the wallet...

Intermittent CI failure "fee too high" in wallet_send.py

5

https://cirrus-ci.com/task/6295015969259520 `wallet_send.py --descriptors` ``` test 2022-04-22T21:26:09.984000Z TestFramework (ERROR): Assertion failed Traceback (most recent call last): File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/test_framework/test_framework.py", line 133, in main self.run_test() File "/tmp/cirrus-ci-build/ci/scratch/build/bitcoin-i686-pc-linux-gnu/test/functional/wallet_send.py", line 560, in run_test assert_fee_amount(testres["fees"]["base"], testres["vsize"],...

ACK appears as stale ACK

1

The ACK [here](https://github.com/bitcoin/bitcoin/pull/16164#issuecomment-499843040) is parsed as a stale ACK. Related to fixed issue #76? Perhaps stale status should also require new commits to exist further down in the HTML than...

BIP32 amendment: base58chk-encoded extended keys are always 111 chars

1

*Replaces https://github.com/bitcoin/bips/pull/727. The description below is copied from that PR.* Base58chk-encoded extended keys are always 111 characters long. Amend wording of BIP32 accordingly. **Diff:** -This results in a Base58-encoded string...