Jon Atack

icon indicating an email [email protected]

Results 455 comments of Jon Atack

github-merge: Add option to overwrite user email

Concept ACK

Bugfix: Address broken things around Peers detail view

Concept ACK. This also cleanly implements https://github.com/bitcoin-core/gui/pull/673#discussion_r1008328740.

Replace MIN_STANDARD_TX_NONWITNESS_SIZE to preclude 64 non-witness bytes only

Tend to agree with https://github.com/bitcoin/bitcoin/pull/26398#pullrequestreview-1186725701 and prefer #26265.

Replace MIN_STANDARD_TX_NONWITNESS_SIZE to preclude 64 non-witness bytes only

Maybe close here, as #26265 was merged.

headerssync: Preempt unrealistic unit test behavior

Concept ACK

bip-324: fix FSChaCha20 type error

Closing due to PR author inactivity, happy to re-open (comment here). Otherwise up for grabs.

doc: cmake: prepend "build" to functional/test_runner.py

(DrahtBot is pinging for a re-review, but the pull hasn't been updated yet.)

doc: cmake: prepend "build" to functional/test_runner.py

Thanks @maflcko (hm, maybe bump the threshold to 2 new ACKs, or drop the rule in this case). Friendly ping to @LarryRuane to update.

doc: cmake: prepend "build" to functional/test_runner.py

ACK e64b2f1a16e8d0ad2cd181d84e3b70312e3cdf33

test: Fix RANDOM_CTX_SEED use with parallel tests

Will review after rebase.