Jonas Haag
Jonas Haag
Oh, nice, didn't know that and should've done more research before making the statement above! I wonder why my patch changes anything in terms of behaviour then (it did in...
Hey @ApolloZhu just wondering if this bug fix will ever make it into the program, otherwise I'll continue using my fork.
I'm also interested in this. I maintain a Git web viewer written in Python, and I'd love to level up the diff rendering game by using delta, which has one...
Yes, either of the interfacing is fine as long as I don’t have to parse ANSI sequences 😀. If you export a C interface that’s even easier to interface from...
Hm not sure what's wrong there.
Hmm maybe we can modify an existing test file and read the page count attribute from the parser. Not really an end to end test but the best idea I...
@mroeschke do you prefer the kind of test I suggested to no test?
One thing I realized is that we could also use NumPy's byteswapping, at the cost of around 10% performance relative to this impl.
> How much of this could be replaced with that? Everything copied from readstat so ~ 50 lines of Cython code
ASV from #47405: ``` before after ratio [e915b0a4] [435a003c] - 81.9±0.7ms 73.7±0.3ms 0.90 io.sas.SAS.time_read_sas7bdat_2_chunked - 78.7±0.7ms 69.5±0.6ms 0.88 io.sas.SAS.time_read_sas7bdat_2 ```