Jonas Haag

Results 800 comments of Jonas Haag

@mroeschke FYI the What's New for 1.5 already include this PR and #47403, but we haven't merged so far.

Test failure seems unrelated to this PR but still worth fixing. I'll need some guidance here. The problem is that we don't have an explicit `.close()` when using `pd.read_sas(iterator=True)` and...

@mroeschke any pointers for the failing test (see comment above)?

Bug in `file_leak_context`, see #30096.

@mroeschke tests fixed, should be good to review now.

This is fixed in one of https://github.com/pandas-dev/pandas/pull/47113 https://github.com/pandas-dev/pandas/pull/47115 (I don't remember which one)

Sure. For starters, run fingerprintjs with a configuration that includes all components and run it on a website with HTTP and HTTPS, and compare the results.

Note that some components change every time you refresh the page, even if not switching between HTTP and HTTPS, so first check what components stay constant when refreshing the page.

It's the same interface just without `env `

OK, we can also fix it in micromamba.