Jonas Haag comments

Results 799 comments of


                                            Jonas Haag

Browserify compatibility

:+1: please merge this

Add manual selection mode 'm'

Bump :)

Update torchaudio resampling

Huh, I did a review very soon after you created this PR. Where has it gone?! Will have to do it again.

torchaudio resampling bug in notebook and updates

Thanks for reporting this! I’m happy to merge the changes but I don’t have the bandwidth to work on it myself so a PR would be very welcome. My suggestion...

Build bjoern error in mac m1 with command `pip3 install --global-option=build_ext --global-option="-I/opt/homebrew/include" bjoern`

https://github.com/jonashaag/bjoern/wiki/Installation

Build bjoern error in mac m1 with command `pip3 install --global-option=build_ext --global-option="-I/opt/homebrew/include" bjoern`

https://github.com/jonashaag/bjoern/issues/226

A Docker image

Cool! The default Docker image doesn't have to cover advanced use cases. I'd say we should expected the application to be mounted to `/app`. I just put together a simple...

A Docker image

For the multi worker implementation, we should not add anything complex. If you want resiliency etc. you usually have other requirements specific to your setup that you need to implement...

pip install fails - missing http_parser.h

Thanks for reporting, this should be fixed with release 3.2.1

Gracefully exiting a Python process running Bjoern

Hm... the way Python implements signals makes it impossible to use them in this situation (C event-loop based server), because they are put into in an internal signal queue and...