Jonah Williams comments

Results 585 comments of


                                            Jonah Williams

[Impeller] skip mip generation if blur downsample is factor is 0.5 or greater

It looks like this causes a validation failure on metal, even if we won't end up reading from a higher mip level. Potentially more fuel for separating out bdfs and...

[Impeller] skip mip generation if blur downsample is factor is 0.5 or greater

Tests did hit this, hence the failure and my comment :)

[Impeller] skip mip generation if blur downsample is factor is 0.5 or greater

Closing in favor of https://github.com/flutter/engine/pull/53760

Change default TileMode for blur ImageFilter objects to null

We're a long way out from a release cut, so assuming the only web change that needs to happen is exposing an API on the canvaskit side, landing this earlier...

Change default TileMode for blur ImageFilter objects to null

The breaking change notice is now waiting on this PR to land: https://github.com/flutter/website/pull/11338

[native_assets_builder] Caching strategy for hook invocations

> Most Targets in flutter tools have static dependencies (List get inputs). I am not entirely sure how dynamic dependencies are handled (List get depfiles). The way this is handled...

[native_assets_builder] Caching strategy for hook invocations

@jtmcdole when I did a hot reload on a flutter project with a moderate amount of assets (flutter gallery) in 2020 , it took more than a second to hot...

Target android_aot_release_android-arm64 failed: ProcessException: Failed to find [...]/bin/cache/artifacts/engine/android-arm64-release/linux-arm64/gen_snapshot" in the search path

I don't think we support linux arm64 as a host for building android appliations, so the artifact is probably not even built. Using the x64 version of gen_snapshot will probably...

Video_player not work on the Android 10 in 3.27.1

What devices? I see Samsung A12. Is that it?

Video_player not work on the Android 10 in 3.27.1

So an emulator? which host platform and what emulator version?