Jonah Williams
Jonah Williams
Amazing. I'll keep looking into it, thank you for checking!
For now I've disabled the usage of mipmaps on all Adreno GPU models: https://github.com/flutter/flutter/pull/161257#event-15845139200 . Please let me know if you still see artifacts after this change. I have some...
Thanks for your patience on this issue. Closing as fixed, with https://github.com/flutter/flutter/issues/161283 open to track re-enabling mipmaps on Adreno.
We don't read the indices though, we pass it to the gpu driver. I suppose we should validate that reasonable things happen there.
verifying on GLES/Vulkan/Metal backend, no crashes. We don't ever read the index data on the CPU
I can add a test at the DL-impeller level and produces a golden. SG?
Jim is out this week. maybe @jtmcdole PTAL?
@chinmaygarde did you mean to close this? We should be able to land it, didn't realize it got reviewed.