Jonah Williams comments

Results 585 comments of


                                            Jonah Williams

Spammy log messages on samsung devices with Impeller enabled.

The fix here will be to filter these out in the flutter tool.

[Impeller] use point/line primitve for hairlines.

I also adjusted some of the alpha scaling params since this doesn't do MSAA specific scaling anymore.

[Impeller] use point/line primitve for hairlines.

I don't know how many times I've mashed rerun but the bot failure seems unrelated.

[Impeller] use point/line primitve for hairlines.

I suspect some of the goldens are just from switching to MaxBasisXY in the fill code. I'm removing that for now.

[Impeller] use point/line primitve for hairlines.

I pulled the max basis change into https://github.com/flutter/engine/pull/55670 (thanks for the review), so whatever is left should just be from this change

[Impeller] use point/line primitve for hairlines.

There is definitely a bug to be found, which I will look for ... next week :)

[Impeller] use point/line primitve for hairlines.

oh wait, its the cross hatches drawn behind the save layers: https://github.com/flutter/engine/blob/92b5b318190b8256ca3e795bdcc2b8912dfa5bde/impeller/display_list/aiks_dl_unittests.cc#L662-L668

[Impeller] use point/line primitve for hairlines.

Its not white path on white background is it?

[Impeller] use point/line primitve for hairlines.

Okay, this is up to date and I've disabled the optimization for round/square caps. Filled https://github.com/flutter/flutter/issues/157618 . I need to do some refactoring of the start/end vector to handle the...

[Impeller] use point/line primitve for hairlines.

I'm having a hard time tracking down the failures in this PR. Instead, I'm going to split this up into smaller changes so i can hopefully find where the error...