Johnny Shields

Let's merge this?

Emily, it's been awhile! I would be great if the Elastic team could consider contributing an instrumentation adapter to the OpenTelemetry project.

@Jimilian thanks for this PR. Please help resolve conflicts on this. I will review and merge promptly if you can do so.

@francisu this one looks good to me, please review and merge

@francisu is there an example of a plugin (this one or other) which converts the config when loading the new version? (I imagine it would also need a "rollback")

@francisu is there any way to display a warning message when you upgrade?

Hey wait a minute, the **existing code** looks like it's comma-delimited... ``` (Arrays.asList(securityGroups.split("\\s*,\\s*"))); ``` This regex splits on commas and removes leading/trailing whitespace. For example, the string "foo bar ,...

Studying a bit more on the problem, according to the docs here: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/using-network-security.html The following are allowed: > a-z, A-Z, 0-9, spaces, and ._-:/()#,@[]+=&;{}!$* So, actually neither comma or semi-colon...

Just a note, this option should not be enabled for spot instances as they cannot reboot.

@francisu I will pickup this feature and combine it with some others I have planned. We can leave this PR open for now.