ec2-plugin icon indicating copy to clipboard operation
ec2-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

Cleanup

Open Jimilian opened this issue 8 years ago • 5 comments

Small code cleanup:

  • Use final if it's possible
  • Use isEmtpy() instead of length comparison
  • Use CONSTANTS instead of 'magic numbers'

Jimilian avatar Apr 14 '16 09:04 Jimilian

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

jenkinsadmin avatar Apr 14 '16 12:04 jenkinsadmin

@Jimilian thanks for this PR. Please help resolve conflicts on this. I will review and merge promptly if you can do so.

johnnyshields avatar May 09 '16 13:05 johnnyshields

@johnnyshields I had solved conflicts

Jimilian avatar May 23 '16 11:05 Jimilian

@francisu this one looks good to me, please review and merge

johnnyshields avatar May 23 '16 11:05 johnnyshields

Hi, looks like there are some more conflicts, sorry about that. Also, can you change back the import *'s. In general, I think it's better to have a separate import for each class. If you do these things, then I will merge it quickly. Thanks for the cleanup, it's nice.

francisu avatar Jun 30 '16 16:06 francisu