John Lees
John Lees
Noted, we will aim to add this in an upcoming version
The intended use of db-qc is after a new database has been created, we would expect QC to be run as part of `poppunk_assign` not separately. Is this not possible...
Hopefully a fix for this in #322, which should appear in v2.7.1. I'm not sure why that has suddenly started happening, and why it doesn't happen in the tests. Also...
i.e. on line 16 add `sorted()` around the right hand side `consonants = sorted(set(string.ascii_lowercase) - set(vowels) - set(trouble))`
Fixed in v2.7.1
Thanks for raising this. - What do you expect the clusters for these samples to be, and why? - Does `--update-db` make any difference? - Have you run any of...
Ah right sorry, update-db won't work with the ref only fit, only the full database. You mentioned in an email you think the v2 database might be the issue. Could...
Ok thanks, I'll look into this at some point soon. I assume using v1 solves your immediate issues?
Can you try with PopPUNK 2.7.0 and see if you get the same? I'm also working on a 'fast' update to meet a lot of your preferred criteria which will...
The error above in 2.7.0 was also reported in #321 (seems to be related to newer versions of python, as it wasn't in changed code). I have PR #322 being...