John Crim
John Crim
Thanks @mattmccleary - will do. I have a few other items of feedback, would be happy to discuss.
I should note that this PR doesn't include any changes to the real-time monitoring client. Once an approach is settled on, it seems likely that the same change should be...
Sorry for the hiccup here - I was just trying to rename my branch (the source of this PR) and accidentally closed the PR. Re-opening.
@cijothomas - I haven't looked at the real-time monitoring client much, but I think the same change should be made there. I hadn't done that due to uncertainty around naming....
Hi @cijothomas - I've resolved the merge conflicts in the PR. I __have not__ made any changes to LiveMetrics. I would be happy to - doesn't look hard - but...
I found that `CategoryName` is included in livemetrics using AppInsights classic, so I'm going to add that to this PR.
I for one would love to see autoTick integrated into sinon.js. I believe it would be useful for many testing use cases. I have migrated some of our angular tests...
Hi @vishweshbankwar - thank you for the response. My point with this issue is that it's problematic to _only_ allow modifying it in the EnrichResponse. If I modify it in...
Also: using `EnrichWithHttpResponse` to set the `DisplayName` is only applicable for RequestIn telemetry. This is also an issue for HttpClient / dependency telemetry.
> @johncrim - Its actually the other way. If you are relying on auto-instrumentation, then in general you would not need to modify the tags or display name set by...