azure-sdk-for-net icon indicating copy to clipboard operation
azure-sdk-for-net copied to clipboard

fix(otel logging): Include ILogger CategoryName in logger output

Open johncrim opened this issue 1 year ago • 2 comments

Previously the CategoryName field from the OpenTelemetry LogRecord was omitted, which was not consistent with normal ILogger behavior, or with Application Insights classic behavior.

fixes: https://github.com/Azure/azure-sdk-for-net/issues/44746

johncrim avatar Jun 27 '24 04:06 johncrim

Thank you for your contribution @johncrim! We will review the pull request and get back to you soon.

github-actions[bot] avatar Jun 27 '24 04:06 github-actions[bot]

I should note that this PR doesn't include any changes to the real-time monitoring client. Once an approach is settled on, it seems likely that the same change should be added there.

johncrim avatar Jul 02 '24 14:07 johncrim

Sorry for the hiccup here - I was just trying to rename my branch (the source of this PR) and accidentally closed the PR. Re-opening.

johncrim avatar Jul 11 '24 04:07 johncrim

@johncrim Could you resolve the merge conflicts?

I am proposing to merge this and include for the imminent release train, but will let @TimothyMothra make the final decision.

cijothomas avatar Jul 12 '24 17:07 cijothomas

@cijothomas - I haven't looked at the real-time monitoring client much, but I think the same change should be made there. I hadn't done that due to uncertainty around naming.

Taking a look at that work right now...

johncrim avatar Jul 12 '24 17:07 johncrim

Hi @cijothomas - I've resolved the merge conflicts in the PR.

I have not made any changes to LiveMetrics. I would be happy to - doesn't look hard - but I would like confirmation that the livemetrics trace document and exception document should have a CategoryName property to match the normal telemetry.

johncrim avatar Jul 12 '24 18:07 johncrim

I found that CategoryName is included in livemetrics using AppInsights classic, so I'm going to add that to this PR.

johncrim avatar Jul 12 '24 19:07 johncrim

API change check

API changes are not detected in this pull request.

azure-sdk avatar Jul 12 '24 19:07 azure-sdk

API change check

API changes are not detected in this pull request.

azure-sdk avatar Jul 12 '24 22:07 azure-sdk