John Crim

Results 103 comments of John Crim

@cijothomas - I think it's desirable for the instrumentation library to provide a good default (which it does), but _not overwrite_ a value that the developer (or another instrumentation library)...

Another option (if you don't like the proposal above) is: 1. When the activity is started, set a default DisplayName as is currently done, and also add that value as...

Hi @YayBurritos - in the cases that I reported, the duplicate listeners don't result in duplicate spans, because the Activities are created/started/stopped by AspNetCore or HttpClient - instead all of...

@vishweshbankwar - The reason it's called more than once is to ensure that AspNetCoreInstrumentation is included. Configuring in multiple locations is a secondary requirement. I'm aware that you can configure...

Hi @MSNev - thanks for the review. I'm not declaring the problematic dependencies nor creating the map files - though they do get combined when the js files are bundled....

Hi @nev21 / @MSNev - it looks like the generated sourcemap for the bundle (which includes app insights and nevware files) includes _both_ `sources` and `sourcesContent`. I can upload the...

Hi @MSNev / @nev21 : Thank you for (mostly) fixing this. The situation is much improved: Now instead of 100 such errors each time I debug the app or tests,...

Hi @MSNev : You're correct, the `file:///C:/src/co/webui` prefix is the path to our project. I provided the full path b/c it's missing the `node_modules` and package-specific paths for each files....

I'm no longer seeing this as of 3.3.9, so from my view it is fixed. @parched yours looks a little different. Is the path within the node_modules dir correct? It...