extended-cpts icon indicating copy to clipboard operation
extended-cpts copied to clipboard

Adds support for value => label definitions in the admin filter options

Open maxchirkov opened this issue 6 years ago • 8 comments

Hi John,

I never created a pull request on github before, so hopefully I didn't screw anything up. So, I implemented the solution I described in my last comment here: https://github.com/johnbillion/extended-cpts/issues/87#issuecomment-384424130

I wrote a test too, but for some reason the mockBuilder would not execute my method and always returned null, so I had to instantiated the Extended_CPT_Admin::class.

Feel free to make adjustments or reject if this doesn't feel right to you.

Thanks for the consideration.

maxchirkov avatar Apr 25 '18 23:04 maxchirkov

I forgot to say thanks for the PR. I won't have much time to look into this soon but I'll get to it when I can!

johnbillion avatar Sep 28 '18 13:09 johnbillion

Looking forward to this merge as I'm facing the same issue, where I need the filter value to be a numeric value.

lmartins avatar Oct 03 '18 10:10 lmartins

I am running in the same problem that was the reason for the pull request. What would help to get the issue fixed?

ibes avatar Apr 15 '19 19:04 ibes

the pull request works well for me. Thanks

ibes avatar Apr 15 '19 19:04 ibes

I need to check whether there's a chance this breaks other functionality that unintentionally passes an associative array of values, but generally I agree this change makes sense.

johnbillion avatar Apr 20 '19 10:04 johnbillion

@johnbillion Do you have an idea when this would be considered? I'm running into the exact same issue as others in the associated issue.

danielpost avatar Sep 01 '21 21:09 danielpost

@johnbillion if only the docks are missing would it be able to merge? I would be happy to send you a markdown doc with the adjusted section regarding callback functions.

JUVOJustin avatar Jun 22 '23 10:06 JUVOJustin