terrapower
Allowing the BOL orientations to be set in the blueprints
What is the change? Why is it being made?
This was a new feature request. In the past, all orientations for high-level BP / Core children start with the same default, because all parameters do.
But there was a design request to be able to start the orientations of each Composite at the start of the run. So here I copy the grid contents parameter over to the orientationBOL parameter, so you can define the orientation parameter of any high-level Composite on any grid.
SCR Information
Change Type: features
One-Sentence Description: Allowing the BOL orientations to be set in the blueprints
One-line Impact on Requirements: NA
Checklist
- [x] This PR has only one purpose or idea.
- [x] Tests have been added/updated to verify any new/changed code.
- [x] The documentation is still up-to-date in the
docfolder. - [x] The code style follows good practices.
- [x] The dependencies are still up-to-date in
pyproject.toml.
@alexhjames My only question here is:
In this PR I only set the Assembly orientation, I don't go through and set orientation parameter for each Block inside the Assembly. Is that... okay?
@alexhjames My only question here is:
In this PR I only set the Assembly orientation, I don't go through and set orientation parameter for each Block inside the Assembly. Is that... okay?
That's fine. Only the assembly orientation is needed.
FYI I do not plan to do another detailed review of this PR, unless you want me to. I gave my feedback without being asked in the first place, so please don't let me hold this up :-)
FYI I do not plan to do another detailed review of this PR, unless you want me to. I gave my feedback without being asked in the first place, so please don't let me hold this up :-)
No worries! Alex and Michael are reviewing this feature. You're free.