Johannes Theiner
Johannes Theiner
Some screenshots in the README would be great ["description": "Show the size of files then you can make superior easy",](https://github.com/JusticHentai/obsidian-size-observer/blob/bd8e996242c8312cef02d1ed9b11f55d3a020fef/manifest.json#L6) I think there is some sort of translation error, the...
[app: App;](https://github.com/DevilRoshan/obsidian-lunar-calendar/blob/dd073fda344a8bd938c9c094bd3be492b58a85bd/src/main.ts#L10) It's highly discouraged that you use the global app instance in your plugin. It's currently accessible from the global context for debugging purposes, and might be removed completely...
[app: App](https://github.com/DevilRoshan/obsidian-lunar-calendar/blob/f32eb132b981a740cf935697ec42521a1395d759/src/main.ts#L9) This was not fixed.
[(leaf) => (this.view = new CalendarView(leaf))](https://github.com/DevilRoshan/obsidian-lunar-calendar/blob/de33e29394e184f881a2e3ee64d7ce9b1ece39c3/src/main.ts#L23) [Avoid managing references to custom views](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Avoid+managing+references+to+custom+views)
[return manifestData.version || 'Unknown';](https://github.com/rmccorkl/TubeSage/blob/dd695c3ed5bca4d38b08e2451f249fde675c50bb/main.ts#L261) Get the version from `this.manifest.version` [const styleEl = document.createElement('style');](https://github.com/rmccorkl/TubeSage/blob/dd695c3ed5bca4d38b08e2451f249fde675c50bb/main.ts#L289-L756) This needs to be in the `styles.css` [name: 'Extract YouTube Transcript',](https://github.com/rmccorkl/TubeSage/blob/dd695c3ed5bca4d38b08e2451f249fde675c50bb/main.ts#L782), [const titleEl = containerEl.createEl('h1', {](https://github.com/rmccorkl/TubeSage/blob/dd695c3ed5bca4d38b08e2451f249fde675c50bb/main.ts#L3624-L3627), [settingsContainer.createEl('h3',...
I don't see all of the requested changes [return manifestData.version || 'Unknown';](https://github.com/rmccorkl/TubeSage/blob/70f746b7d827891a7ac9fa815c64b3055923fd84/main.ts#L262) Use `this.manifest.version` to get the version number. [const styleEl = document.createElement('style');](https://github.com/rmccorkl/TubeSage/blob/70f746b7d827891a7ac9fa815c64b3055923fd84/main.ts#L290-L761) This should be part of the `styles.css`...
[ const styleEl = document.createElement('style');](https://github.com/rmccorkl/TubeSage/blob/740efd85c4a69fdd32bed2c47d3a0ab6874f1470/main.ts#L290-L293) This is not necessary, Obsidian will already load that file.
Sorry, but that's just not true, something else is breaking the CSS. The bug you are linking to is part of another plugin, not the Obsidian app, which was fixed...
Remove the settings tab header and the manual CSS loading.
[Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Only+use+headings+under+settings+if+you+have+more+than+one+section.)