Johannes Theiner

Results 730 comments of Johannes Theiner

No, monorepos are not supported. And using inheritance is preferred in Obsidian plugin development.

You have not applied fixes for most of my feedback.

Refactor the ConfirmDeleteModal to use inheritance. And update your UI strings to use sentence case.

I don't see any changes here. Can you check and make sure that nothing got lost during the merge?

[import sindreDebounce from 'debounce'](https://github.com/kitschpatrol/yanki-obsidian/blob/8b2f9a91e151f4aaab0d44b3d7724d1687492a71/src/main.ts#L19) Use the `debounce` function from the Obsidian API instead of importing a third party library.

[return "Graph View";](https://github.com/nicoletanyt/obsidian-plugin-graphs/blob/17db679ec488628d5f2a058d76e7faa0057efaee/main.ts#L46), [name: 'Generate Graph',](https://github.com/nicoletanyt/obsidian-plugin-graphs/blob/17db679ec488628d5f2a058d76e7faa0057efaee/main.ts#L82), [name: 'Draw Vector',](https://github.com/nicoletanyt/obsidian-plugin-graphs/blob/17db679ec488628d5f2a058d76e7faa0057efaee/main.ts#L110), [new Notice('Drawing Vectors...');](https://github.com/nicoletanyt/obsidian-plugin-graphs/blob/17db679ec488628d5f2a058d76e7faa0057efaee/main.ts#L132), [new Notice("Invalid Syntax")](https://github.com/nicoletanyt/obsidian-plugin-graphs/blob/17db679ec488628d5f2a058d76e7faa0057efaee/main.ts#L136), [.setName("X Axis")](https://github.com/nicoletanyt/obsidian-plugin-graphs/blob/17db679ec488628d5f2a058d76e7faa0057efaee/main.ts#L193-L194), [.setName("Y Axis")](https://github.com/nicoletanyt/obsidian-plugin-graphs/blob/17db679ec488628d5f2a058d76e7faa0057efaee/main.ts#L204-L205), [.setName("Disable Zoom")](https://github.com/nicoletanyt/obsidian-plugin-graphs/blob/17db679ec488628d5f2a058d76e7faa0057efaee/main.ts#L215), [new Notice("ERROR: Invalid Syntax");](https://github.com/nicoletanyt/obsidian-plugin-graphs/blob/17db679ec488628d5f2a058d76e7faa0057efaee/GraphViews.tsx#L59), [new Notice("ERROR: Invalid Syntax");](https://github.com/nicoletanyt/obsidian-plugin-graphs/blob/17db679ec488628d5f2a058d76e7faa0057efaee/GraphViews.tsx#L82), ["The...

["description": "A plugin to assist with writing lyrics by counting syllables per line.",](https://github.com/anthonybrunelle/lyricist-helper-obsidian/blob/9c1c6bc85a48ecad69ca0a4a543fabb531b04e18/manifest.json#L6) Avoid including sentences like "This is a plugin that does ..." in your description, it should be...

[interface MathIndicatorChangerSettings {](https://github.com/Ori-Replication/obsidian-math-indicator-changer/blob/d527d19fd84a69a237845f73484317358cf6ec5b/main.ts#L3-L9), [settings: MathIndicatorChangerSettings;](https://github.com/Ori-Replication/obsidian-math-indicator-changer/blob/d527d19fd84a69a237845f73484317358cf6ec5b/main.ts#L12), [async loadSettings() {](https://github.com/Ori-Replication/obsidian-math-indicator-changer/blob/d527d19fd84a69a237845f73484317358cf6ec5b/main.ts#L95-L101), [await this.loadSettings();](https://github.com/Ori-Replication/obsidian-math-indicator-changer/blob/d527d19fd84a69a237845f73484317358cf6ec5b/main.ts#L15) Your plugin does not have any settings, remove this code. [this.addRibbonIcon('dollar-sign', 'Change Math Indicator'](https://github.com/Ori-Replication/obsidian-math-indicator-changer/blob/d527d19fd84a69a237845f73484317358cf6ec5b/main.ts#L17), [name: 'Change Math Indicator',](https://github.com/Ori-Replication/obsidian-math-indicator-changer/blob/d527d19fd84a69a237845f73484317358cf6ec5b/main.ts#L44) [Use sentence...

[name: 'Change Math Indicator',](https://github.com/Ori-Replication/obsidian-math-indicator-changer/blob/9f55a26f0b99c548ce3de57644f86d035112482e/main.ts#L32) [Use sentence case in UI](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI)

Still waiting on this: [name: 'Change Math Indicator',](https://github.com/Ori-Replication/obsidian-math-indicator-changer/blob/9f55a26f0b99c548ce3de57644f86d035112482e/main.ts#L32) [Use sentence case in UI](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI)