Johannes Theiner

[// Adapted from Templater plugin https://github.com/SilentVoid13/Templater](https://github.com/adanielnoel/obsidian-index-notes/blob/86d9722d68f80032e586cbd88ea4db61c1ba4166/src/settings/suggesters/suggest.ts#L1-L202) Use `window.open` instead of the electron API. [.setDesc('Your personal access token for the ESA API')](https://github.com/taichimaeda/esa-sync/blob/5a828a8e8ca32dac87a384ab1c238e8216e0ce96/src/settings.ts#L42), [contentEl.createEl('h2', { text: 'Esa Sync' });](https://github.com/taichimaeda/esa-sync/blob/5a828a8e8ca32dac87a384ab1c238e8216e0ce96/src/api.ts#L199) Please stay consistent...

Remove the `styles.css` file from your release, since it's empty it's just unnecessary bloat.

["minAppVersion": "0.12.0",](https://github.com/taskscape/ObsidianUniqueFileName/blob/670928aacf13342fd1f65fb91bac7b28e6361cb2/manifest.json#L5) You are using newer API's, set this to the latest public build number. ["description": "This plugin renames currently selected file by providing it a unique file name based...

Please update your readme to document your plugin and remove the instructions for developing a new plugin.

["css": "styles.css"](https://github.com/Eloliuyx/everyday-classical-music-plugin/blob/5d10777a0bb48c7cfaa5a655dbc60b1fdc8859b7/manifest.json#L10) This is not a part of the manifest spec, remove it. [import * as fs from 'fs';](https://github.com/Eloliuyx/everyday-classical-music-plugin/blob/5d10777a0bb48c7cfaa5a655dbc60b1fdc8859b7/main.ts#L2-L3) These imports are only available from a Node.js runtime, which means...

[.setName('Backfill Existing Notes')](https://github.com/Eloliuyx/everyday-classical-music-plugin/blob/29b210dd611c58a1144d187ad517f292ada82534/main.ts#L1971), [.setName('Remove Links Before Date')](https://github.com/Eloliuyx/everyday-classical-music-plugin/blob/29b210dd611c58a1144d187ad517f292ada82534/main.ts#L1984), [button.setButtonText('Remove Links')](https://github.com/Eloliuyx/everyday-classical-music-plugin/blob/29b210dd611c58a1144d187ad517f292ada82534/main.ts#L1996) [Use sentence case in UI](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI)

It looks like you forgot to push.

["authorUrl": "",](https://github.com/Lio5n/peekaboo/blob/33b4dc26aa50514f235245c7f55c4cf72e04c7b7/manifest.json#L8) This needs to be filled, if you don't have a website use your GitHub profile url. [if (!this.settings.hideRibbonIcon) {](https://github.com/Lio5n/peekaboo/blob/33b4dc26aa50514f235245c7f55c4cf72e04c7b7/src/main.ts#L27-L31), [new Setting(containerEl)](https://github.com/Lio5n/peekaboo/blob/33b4dc26aa50514f235245c7f55c4cf72e04c7b7/src/settings.ts#L112-L122) As of v1.1.0 of Obsidian, the ribbon...

That exactly the problem, if the plugin provides a ribbon icon, then it should always be possible to change its visibility from the app settings/right-click.

Sorry for the delay. [if (this.ribbonIconEl) {](https://github.com/Lio5n/peekaboo/blob/05ff8b4f4719eea4dfca55b12f4964a2cbabd40c/src/main.ts#L40-L42), [if (!plugin.ribbonIconEl) {](https://github.com/Lio5n/peekaboo/blob/05ff8b4f4719eea4dfca55b12f4964a2cbabd40c/src/ribbon.ts#L127-L128) That is not neccessary, Obsidian already handles that. [containerEl.createEl('h2', { text: 'Hidden Files' });](https://github.com/Lio5n/peekaboo/blob/05ff8b4f4719eea4dfca55b12f4964a2cbabd40c/src/settings.ts#L45) [Only use headings under settings if...