Johannes Theiner

Results 730 comments of Johannes Theiner

[console.log(`Tracked operation: ${changeType} - ${file.path} from ${oldPath}`);](https://github.com/19msb/obsidian-file-flex/blob/38dae823b8964cda70c1dfbaf93f907a5940c256/main.js#L63), [console.log(`Successfully moved ${fileOp.newPath} to ${fileOp.oldPath}`);](https://github.com/19msb/obsidian-file-flex/blob/38dae823b8964cda70c1dfbaf93f907a5940c256/main.js#L83) Please avoid unnecessary logging. If you need it for debugging purposes, add a check to only log during...

[ - On Windows: `%APPDATA%/Roaming/obsidian/plugins`](https://github.com/19msb/obsidian-file-flex/blob/357ec08ba0703479c767665ea804b2bb4f1e8448/README.md?plain=1#L16-L18) These paths are not correct, users can decide where they want to place their vault.

[this.developerMode = this.app.vault.getConfig('developerMode') || false;](https://github.com/19msb/obsidian-heading-path/blob/a34118d32d8d280d891817aaad21e17a2d14026c/main.js#L13) "developerMode" does not exist. [const editor = this.app.workspace.getActiveViewOfType(MarkdownView)?.editor;](https://github.com/19msb/obsidian-heading-path/blob/a34118d32d8d280d891817aaad21e17a2d14026c/main.js#L90) To get the active editor use `this.app.workspace.activeEditor?.editor` This will also work in Canvas. [containerEl.createEl('h1', { text: 'Custom...

["Toggle NSFW Visibility",](https://github.com/catvatar/Obsidian-NSFW-Plugin/blob/ebd674004f712de9de103dbd0d2fac265aceb7ab/src/main.ts#L29), [containerEl.createEl("a",{ text: 'Read More', href: 'https://help.obsidian.md/Plugins/Search' });](https://github.com/catvatar/Obsidian-NSFW-Plugin/blob/ebd674004f712de9de103dbd0d2fac265aceb7ab/src/settings.ts#L47) [Use sentence case in UI](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI) [if (this.settings.toggleEye) {](https://github.com/catvatar/Obsidian-NSFW-Plugin/blob/ebd674004f712de9de103dbd0d2fac265aceb7ab/src/main.ts#L26), [new Setting(containerEl)](https://github.com/catvatar/Obsidian-NSFW-Plugin/blob/ebd674004f712de9de103dbd0d2fac265aceb7ab/src/settings.ts#L83-L92) As of v1.1.0 of Obsidian, the ribbon can be customized...

(skipped) [this.addRibbonIcon('create-new', 'Create New Entry', this.createNewEntry.bind(this))](https://github.com/wholetomy/obsidian-e-daiary/blob/7740493a4a93324475909be0e1e7cd5361040f4d/main.ts#L19) [Use sentence case in UI](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI) Also, you should add a command that does the same thing, the ribbon can be disabled by the user,...

[name: 'Create New Entry',](https://github.com/wholetomy/obsidian-e-daiary/blob/c34f8e79955fc6309d9be88f803c6d22e6733c03/main.ts#L25) This is not using sentence case.

The `data.json` file should not be part of the repo, remove it and add it to the `.gitignore` ["description": "Adds a badge to \"project\" files when they miss a link...

Repeating the review issues again since the line numbers changed. The `data.json` file should not be part of the repo, remove it and add it to the .gitignore [function getFrontMatter(markdownString:...

["permissions": ["clipboard-write"]](https://github.com/msgk239/obsidian-copy-image-text/blob/e84ce324ba2e2d53bbc1eef536e17764cf3170f2/manifest.json#L9) This is not a thing, remove this line. [arrayBufferToBase64(buffer: ArrayBuffer): Promise {](https://github.com/msgk239/obsidian-copy-image-text/blob/e84ce324ba2e2d53bbc1eef536e17764cf3170f2/main.ts#L103-L114) That is already a function in the Obsidian API, use that.

[let app: App;](https://github.com/joycode-hub/datepicker-plugin/blob/6a500d18687da26110a1e680e16cca37f629c63a/main.ts#L9-L11) You should not use global variables whenever possible, read here why: http://wiki.c2.com/?GlobalVariablesAreBad [app = this.app;](https://github.com/joycode-hub/datepicker-plugin/blob/6a500d18687da26110a1e680e16cca37f629c63a/main.ts#L168) And specifically don't keep a global reference to the app object. [onunload()...