Johannes Theiner

Results 730 comments of Johannes Theiner

You haven't made any of the sentence case changes yet.

You missed 17 of those.

There are still 2 missing

["minAppVersion": "0.15.0",](https://github.com/chasebank87/unofficial-fabric-plugin/blob/3b350af3c044dbcef65b67600fc7bac7ad4871a7/manifest.json#L5) You are using newer API's, set this to the latest public build number. ["fundingUrl": "https://github.com/chasebank87/unofficial-fabric-plugin.git",](https://github.com/chasebank87/unofficial-fabric-plugin/blob/3b350af3c044dbcef65b67600fc7bac7ad4871a7/manifest.json#L9) This is meant for links to services like _Buy me a coffee_, _GitHub...

`minAppVersion` was not updated, and it looks like I forgot to add a reason why it needs to be changed, updated my comment above.

[# Obsidian Papers](https://github.com/willjhliang/obsidian-papers/blob/4dc753c9a0f26996146ceeab3b3717f910e692f7/README.md#L1) Naming something "Obsidian xyz" is reserved for first party products we create, please change this header. [name: "Import from Clipboard",](https://github.com/willjhliang/obsidian-papers/blob/4dc753c9a0f26996146ceeab3b3717f910e692f7/main.ts#L63), [titleEl.setText("File Exists");](https://github.com/willjhliang/obsidian-papers/blob/4dc753c9a0f26996146ceeab3b3717f910e692f7/main.ts#L481) [Use sentence case in UI](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI)...

The proper way would be to call `.hide()` / `.show()` on the element. There is also `.toggleVisibility()` and `.isShown()`

["description": "Integration plugin with Yandex Wiki knowledge base",](https://github.com/CubieProg/Obsidian-Yandex-Wiki-Integration/blob/a6ca0c6d37ba332a9af7aff7c3128c74d92a1261/manifest.json#L6) Don't include the word "plugin" in the description. ["fs": "^0.0.1-security",](https://github.com/CubieProg/Obsidian-Yandex-Wiki-Integration/blob/a6ca0c6d37ba332a9af7aff7c3128c74d92a1261/package.json#L43-L45) These are not valid dependencies you can put here, they are part...

[# Obsidian Agenda Plugin](https://github.com/elias-shalom/obsidian-agenda/blob/0bfb8e89e6a892234d6f2d8ba8256760168ed530/README.md#L1) Naming something "Obsidian xyz" is reserved for first party products we create, please change this header. [private async loadStyles(): Promise {](https://github.com/elias-shalom/obsidian-agenda/blob/0bfb8e89e6a892234d6f2d8ba8256760168ed530/src/main.ts#L69-L89), [document.querySelectorAll('style[data-plugin="obsidian-agenda"]').forEach(element => {](https://github.com/elias-shalom/obsidian-agenda/blob/0bfb8e89e6a892234d6f2d8ba8256760168ed530/src/main.ts#L108-L110) Obsidian does...

[this.view = new RelatedNotesView(leaf, this);](https://github.com/chrishoward-projects/related-notes-by-tag/blob/1c21dda5da80071e1a17f676d66cf81f8a38403f/src/main.ts#L18) [Avoid managing references to custom views](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Avoid+managing+references+to+custom+views) [containerEl.createEl('h2',{text:'Related Notes by Tag'});](https://github.com/chrishoward-projects/related-notes-by-tag/blob/1c21dda5da80071e1a17f676d66cf81f8a38403f/src/settings.ts#L32) [Don't add a top-level heading in the settings tab, such as "General", "Settings", or the...