Johannes Theiner

Results 730 comments of Johannes Theiner

["fundingUrl": "https://jordane.day",](https://github.com/jordaeday/canvas-task-importer/blob/224d64187a033c026be5ed3c079225fcea2854bd/manifest.json#L9) This is meant for links to services like _Buy me a coffee_, _GitHub sponsors_ and so on, if you don't have such a link remove this line. [link:...

[canvas](https://github.com/jordaeday/canvas-task-importer/blob/0643621beaa5081e9d949b364197ce31079a34a4/src/main.ts#L24), [canvas](https://github.com/jordaeday/canvas-task-importer/blob/0643621beaa5081e9d949b364197ce31079a34a4/src/main.ts#L42C11-L42C15) Canvas is a brand name here, so it's written as on their website, so "Canvas"

["settings": {},](https://github.com/aa-parky/front-matter-next-review-date/blob/cc53219c072e34d5078fcff256f8d41398cdccb4/manifest.json#L10-L22) This is not a valid part of the manifest, remove it. [.setName("Enable Plugin")](https://github.com/aa-parky/front-matter-next-review-date/blob/cc53219c072e34d5078fcff256f8d41398cdccb4/main.js#L108-L116) This should not be a setting, there is already a toggle in the Community Plugins...

["author": "Andreas Varotsis ",](https://github.com/AndreasThinks/obsidian-to-quarto-exporter/blob/888fb1eefbcf1c04838daa6b1be9000d5f5046b5/manifest.json#L7) This field is displayed in the sidebar and in the description for the plugin details page. Are you sure you want to have your email listed...

[new Setting(containerEl).setName('Active Folder Highlighter').setHeading();](https://github.com/justanotherjurastudent/highlight-active-folder-section/blob/d123de7b7b811235965123c4cb308cbc5dfd4152/main.ts#L178) [Don't add a top-level heading in the settings tab, such as "General", "Settings", or the name of your plugin.](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Only+use+headings+under+settings+if+you+have+more+than+one+section.) ['Folder Section Background-Color'](https://github.com/justanotherjurastudent/highlight-active-folder-section/blob/d123de7b7b811235965123c4cb308cbc5dfd4152/main.ts#L270), ['Folder Background Color')](https://github.com/justanotherjurastudent/highlight-active-folder-section/blob/d123de7b7b811235965123c4cb308cbc5dfd4152/main.ts#L274), ['Folder...

These two are not using sentence case: - https://github.com/justanotherjurastudent/highlight-active-folder-section/blob/d22fc9509551d1a4aa4e6bf5eb562bfda58b9617/main.ts#L178 - https://github.com/justanotherjurastudent/highlight-active-folder-section/blob/d22fc9509551d1a4aa4e6bf5eb562bfda58b9617/main.ts#L328

[Copyright (c) 2024 Will Lewis](https://github.com/GoBeromsu/british-pronunciation-plugin/blob/930400bfed82ceac2c547b60c65d013e3fd182fa/LICENSE.md#L3) That name feels wrong, [name: "Pronounce Selected text",](https://github.com/GoBeromsu/british-pronunciation-plugin/blob/930400bfed82ceac2c547b60c65d013e3fd182fa/main.ts#L10) [Use sentence case in UI](https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines#Use+sentence+case+in+UI) [editorCallback: (editor) => this.pronouncSelectedText(editor),](https://github.com/GoBeromsu/british-pronunciation-plugin/blob/930400bfed82ceac2c547b60c65d013e3fd182fa/main.ts#L11) This should be a [`editorCheckCallback`](https://docs.obsidian.md/Reference/TypeScript+API/Command/editorCheckCallback), that way the...

[Command Pallet](https://github.com/chasebank87/import-github-readme/blob/d49c5154f1757c70bf947b47217afc45a6cf3c0d/README.md#L3) It's called ["Command palette](https://help.obsidian.md/Plugins/Command+palette) ["description": "Allows you to import a GitHub README file into your vault.",](https://github.com/chasebank87/import-github-readme/blob/d49c5154f1757c70bf947b47217afc45a6cf3c0d/manifest.json#L6) Avoid sentences like "Allows you to do ..." We have published a...

Why are you using marked in that function and not `htmlToMarkdown` ?

Okay, but one thing you need to handle here, Marked does not sanitzie the content that gets produced, use the `sanitizeHTMLToDom` function for that.