Joe Bell

Results 63 comments of Joe Bell

I'm feeling like we could resolve this through a number of different options: * Naming - is the naming of our variables something we could improve? * Commenting - do...

I think I'd actually agree with @MrDinsdale's view of >"We could look to move any variables which could be beneficial to global usage into settings?" Not necessarily move, but actually...

@MrDinsdale what do you propose for this? Just cautious of the fact this has been open since last August!

Introduced class without suffix in [`v2.23.1`](https://github.com/sky-uk/toolkit/blob/v2.23.1/packages/sky-toolkit-core/CHANGELOG.md), let's remove `-all` and deprecate in `v3.0.0`

@MrDinsdale is it worth looking into [Danger](http://danger.systems/js/)?

Wondering if this is better being a generic link class for use outside of panels? Very much like `.c-link-external`, we could have `.c-link-back`

We can do a cheeky BEM mix 🔥 `"c-link-back c-panel__link-back"`

Replicating the following designs from Sketch: ![screen shot 2017-11-30 at 10 25 25](https://user-images.githubusercontent.com/7349341/33426189-e3fd8c6a-d5b8-11e7-9256-03d9a0568b60.png) ![screen shot 2017-11-30 at 10 25 44](https://user-images.githubusercontent.com/7349341/33426194-e6b620c0-d5b8-11e7-9ad7-07d54a573a00.png) --- @mikejgregory just checking that it's intentional for the back...

It's a little complicated to explain, but the answer to that is yes and no due to us using `png`s. I'll have a chat later with you

@sky-uk/toolkit-owners I'm thinking we split this into a short-term and long-term option: --- Short-term ``` Back Close ... ``` --- Long-term The extra `c-panel__nav` would remove any need to absolutely...