toolkit icon indicating copy to clipboard operation
toolkit copied to clipboard

Revisit automation/linting of branch naming and commit conventions

Open MrDinsdale opened this issue 6 years ago • 2 comments

Expected Behaviour

Given our strict conventions regarding the commit strategy it would be great to enforce via automation and/or linting to prevent issues.

Current Behaviour

Many who haven't followed our contribution guide do not follow the commit strategy (which differs significantly from other projects) causing frustration when it comes to requesting reviews.

By adding automation and linting (if feasible) to our branch naming and commit messages we could prevent this before it becomes a problem.

Attempted Fixes

n/a

Steps to Reproduce (for bugs)

n/a

Context

This affects many less familiar with our commit strategy or perhaps those who haven't contributed for a while.

Your Environment

n/a

MrDinsdale avatar Apr 16 '18 09:04 MrDinsdale

@MrDinsdale is it worth looking into Danger?

joe-bell avatar May 16 '18 10:05 joe-bell

I think Danger would be ace and is great for reducing pain for reviews by catching common issues early however I think most of the confusion happens before that point with the initial branching. I wonder if we can help guide people through the initial naming and commits with out having to go back and rewrite the history etc.

MrDinsdale avatar Jun 26 '18 13:06 MrDinsdale