Joe Bell comments

Results 63 comments of


                                            Joe Bell

Select toggle seems to remain "selected" after de-selection

@rdp84 Is this for sky.com/toolkit? If it is, those examples don't have JavaScript and are purely to demo interaction states. Closing this issue until the above PR template has been...

Select toggle seems to remain "selected" after de-selection

@sky-uk/toolkit why don't we use the [same technique we use for Switch](https://github.com/sky-uk/toolkit/blob/27cd7fb60359a76042b794b862c590291d4710d4/packages/sky-toolkit-ui/components/_switch.scss#L46)? ```css @media(pointer: coarse) {}; ```

jplayer youtube implementation

Thanks for all your hard work on jPlayer, it's great. Is a YouTube feature still in the works?

feat: expose params to optimize base64 images

Thanks for your efforts on this @joeyhage, I'll be implementing via #214 With your permission, I'd love to include you as a co-author to the relevant commits. Let me know...

feat: add publicdir for options

Closing in favour of #212 (@JaeSeoKim [please see my comment in #212](https://github.com/joe-bell/plaiceholder/pull/212#issuecomment-1228482342) – I don't want your efforts to go unnoticed!)

feat: expose image processing params to api for end user to customize

Thanks for your efforts on this @kruserr, I'll be implementing via #214 With your permission, I'd love to include you as a co-author to the relevant commits. Let me know...

Tree shaking not working when importing from a component library inside a MDX file

I've actually noticed that I have a similar experience with local components – unused ones aren't eliminated from the resulting bundle

node-canvas runtime error

Thank you @shawninder!

Unexpected Type Definition for `class` and `className`

Hmm, please can you private a working reproduction? (not code snippets, but a sandbox of some sorts)

cx error Argument of type 'false' is not assignable to parameter of type 'ClassValue'

Unable to recreate this – I'm using `false` in many projects with no issues. Please provide a working reproduction