toolkit icon indicating copy to clipboard operation
toolkit copied to clipboard

Should we rename the `-all` suffix in our spacing utilities?

Open joe-bell opened this issue 6 years ago • 2 comments

Description

To keep things short and sweet, should we remove the -all suffix and rename to:


/* previously `.u-padding-all` */
.u-padding {
  padding-top: 20px;
  padding-right: 20px;
  padding-bottom: 20px;
  padding-left: 20px;
}

I think this is much tidier but I'm aware it's a breaking change. What do people think?

Context

Enhance Toolkit developer experience

joe-bell avatar May 21 '18 14:05 joe-bell

I approve, could always do a soft rollout of this with:

.u-padding,
.u-padding-all {...}

That way we can introduce it and start transitioning over straight away rather than going full breaking change at 3.0.

MrDinsdale avatar May 22 '18 07:05 MrDinsdale

Introduced class without suffix in v2.23.1, let's remove -all and deprecate in v3.0.0

joe-bell avatar Jul 04 '18 15:07 joe-bell