Joseph Musser

Results 395 comments of Joseph Musser

@CharliePoole Thanks. What I'm hearing is that using runners sequentially should be allowed and using them concurrently should not. Right now `ITestAgent` and `ITestAgency` are the protocol definition between the...

Decoupling the runner interface from the agent protocol (ITestAgent) and incrementally morphing ITestAgent as an internal implementation detail into the same shape as the internal wire protocol will save me...

@ChrisMaddock Right, the agency would allow sequential runners to be created. Under the covers, creating a new runner would be implemented by sending the protocol message of calling `ITestAgency.Load(TestPackage)` (notice...

One thing I didn't address is if we wanted ITestAgent to be a more general concept rather than a communication implementation detail. Well... that's a lot of up-front work. Remoting...

By being extensible, I'm hoping the design doesn't require much foresight at all. 😊 I'm building the protocol with the assumption that we will be connecting servers and clients of...

@CharliePoole > I hope you won't eliminate the API distinction between agent and runner. Nope, if anything I'm trying to make the boundary even more distinct. ITestRunner and its uses...

What I would like to leave out of the wire protocol is the ability to use more than one runner at a time. Given that ITestAgent will representing the wire...

Not yet, though the first draft PR was 95% of it. I'm just starting to rewrite from scratch in https://github.com/jnm2/nunit-console/tree/replace_remoting_2/src/NUnitEngine/nunit.engine/Communication. Do you think it's worth drawing something up based on...

It's the one from 15 (😱) months ago that you've seen: https://github.com/nunit/nunit-console/pull/576 I'm keeping it as a loose reference.

That PR implemented the protocol without documenting it. In my new branch, I'm making a struct for each message to model it: https://github.com/jnm2/nunit-console/blob/replace_remoting_2/src/NUnitEngine/nunit.engine/Communication/Model/ConnectAsAgentWorkerRequest.cs But I am not working far ahead...