Jenny Messerly comments

Results 101 comments of


                                            Jenny Messerly

Inserting dart.notNull checks by default on a loop iteration variable

we could also do `--trust-primitives` flag like dart2js does

Inserting dart.notNull checks by default on a loop iteration variable

@ochafik -- if I understand correctly, the runtime code we inherited from dart2js already has this non-null magic, so your change just teaches DDC to recognize the pattern? If so...

Need renamer for module exports introduced by the compiler

Current examples of introduced names: `List$` for `List` and `$add` for the extension method `List.add`

Need renamer for module exports introduced by the compiler

Also, these should probably use a different naming convention from temps.

Need renamer for module exports introduced by the compiler

note: extension methods were fixed (moved to a different namespace) so only the generic type vs dynamic instance is left. > One obvious way to do this is to reserve...

Metadata annotations should be stored

https://codereview.chromium.org/1177563003/ fixes classes. Will we want methods and other things at some point?

const list/map should be immutable

we could use Object.freeze, that will protect the array from JS too

const list/map should be immutable

I tired out freeze, the catch is we can't throw expandos on the object later (like hashCode). Weak maps are one alternative, another is just to precompute identityHashCode and such.

use Angular's zone.js for implementing zones

> In general, can we implement the Dart event loop on top of angular zones? yup, should be able to

most source map paths are off by one

Good catch! Path computation happens at: https://github.com/dart-lang/dev_compiler/blob/e465c1df13f9ad50b5dff3e120fe116718561753/lib/src/compiler.dart#L417 I think the "packages" magic happens here: https://github.com/dart-lang/dev_compiler/blob/e465c1df13f9ad50b5dff3e120fe116718561753/lib/src/codegen/code_generator.dart#L79 The two do not appear to know about each-other... (not sure this is low priority...