Jenny Messerly

Results 101 comments of Jenny Messerly

I think this is probably a build/bazelify issue so moving to that repo

Yeah I want to add on to Leaf's question ... could you link to the code where you're implementing this? Are you trying to see if the string value "thisShouldWork"...

instantiateToBounds on TypeSystem (which should be an instance of StrongTypeSystemImpl in strong mode) will do what your first line does, and get the instantiated type. I think the answer in...

it does not currently work in strong mode: ```dart class MyComponent { A stringBound; } main() { var x = new MyComponent(); x.stringBound = 'hello'; print(x.stringBound); } ``` ``` $...

Update: if I reverse the order it works in strong mode: ```dart class MyComponent { A stringBound; } main() { var x = new MyComponent(); x.stringBound = 'hello'; print(x.stringBound); }...

this is covered by https://github.com/dart-lang/sdk/issues/27072

yeah it's a great test case! 👍 I think that's right... you'll want to typeSystem.instantiateToBounds on the `MyComponent` type, however you're getting that. Conceptually it's what happens when you write...

> Also worth noting, we are traversing the ast of the class to build up a model of a directive when this happens, so I am going from a Node...

yeah I think you definitely will want to use instantiateToBounds over substitute2. The latter is for something very specific, it's best thought of as a low level primitive that we...