Jenny Messerly

Results 101 comments of Jenny Messerly

review suggestion ... your "getBound" is just `type.resolveToBound(typeProvider.dynamicType)`

another review suggestion: instead of `new List() ..addAll(classElement.typeParameters.map(getBound));`, use `new List.from(...)` or `.toList()` but yeah I would definitely recommend instantateToBounds, if you don't want non-strong mode behavior, you could always...

hmmm. Does dartanalyzer find this? We should be displaying all of those errors. I wonder if that reporting got busted somehow. What commands did you use to run DDC?

Ah, nice find! Sounds like an analyzer bug ... or maybe a bug that other Dart impls display an error. Not sure, would have to double check spec

Nice! I wonder if we can have an extension or something that sets this up automatically. (Of course, you'd still have to install the extension. But we could have a...

yup. A lot of the HTML ones look internal to the HTML library cycle, right? So we could ignore everything under "dart.dom"

also NativeTypedArray shouldn't be user-visible type same with _interceptors, _js_helper, _internal So the list of types this primarily affects is: - dart.collection - ListMixin - dart.core - Comparable - dart.core...

@vsmenon -- I thought we weren't going to support user-defined implementations of DOM types? There's a difference between something that can be _implemented_ by a pure Dart type, vs something...

just to be clear with an example, I'm concerned about: ``` dart class MockElement implements Element { // pretend to be an HTML element! } ``` To pick one obvious...