Jackie McDoniel

Results 231 comments of Jackie McDoniel

Again, apologies for the delay. My personal life has been rather hectic as of late. @asif-jalil I think the only other thing I could ask for for this is a...

Okay, I think the recent minor change I merged in added some conflicts, but if you get those fixed up I'll get this merged soon after

This would mean that we also need to keep track of the timing for the block duration as a part of the ThrottlerGuard, right? Or are you thinking of implementing...

I think I'd like to see a PR for this. Would you like to make it off the `feat/mutliple-throttlers` branch, as that's the current 5.0.0 target? Just to make sure...

So I see two options here: 1) leave this to the developer to create a memoization function for it (not hard to create, but possibly not the best DX) 2)...

That would entirely depend on _when_ the `req.user` gets populated. Usually this is done by the `AuthGuard()` unless you have a custom solution, and most people would have that bound...

`serviceErrorHandler` was created to handle errors that happen during `this.commander.parseAsync` [as detailed in this PR](https://github.com/jmcdo29/nest-commander/pull/802), whereas `errorHandler` is the general commander error handler and modifies how errors at the commander...

Technically, the output of `process.stdout` is what would get assigned to that variable. So a simple `process.stdout.write('Whatever')` would set `$MY_VAL` to `'Whatever'`

If the `run` were allowed to return a value, the underlying service runner would do that same thing of `process.stdout.write(result)`. It's not really hacky, it's just how return values in...

Would I be able to request a review for this? Please and thank you