Jackie McDoniel

Results 231 comments of Jackie McDoniel

Hmm, I was not able to reproduce this functionality in an e2e test I created for this issue. Can someone provide me a [minimum reproduction](https://minimum-reproduction.wtf)

> Is nestjs abandoned? @knownasilya what gave you that idea? Kamil is literally working on the v10 branch and has been for the past few weeks. Just because this API...

[We do have this mentioned](https://docs.nestjs.com/fundamentals/injection-scopes#scope-hierarchy) > The REQUEST scope bubbles up the injection chain. A controller that depends on a request-scoped provider will, itself, be request-scoped. If you think explicitly...

If you think it would help to mention that the `REQUEST` token is `REQUEST` scoped, then I think it would be good to add it. I'm well aware of this...

If you'll notice, this is _actually_ a different filter than the one mentioned above, and thus has a different signature and parameters. Just above is a full implementation while this...

Okay, I think I see the request here. Instead of being forced to use the `ThrottlerModule` it would be nice to set the `@UseGuards()` and `@Throttle()` on a case-by-case basis,...

The idea I suggested was just to make sure that there _was_ a default config so that the `@Throttle()` override properly works. So long as the guard is not applied...

> Having same problem - I do use module with default configuration, however there are routes that I would like to use different rate limit that is defined in module....

From a quick pass it looks pretty good, I'll need to go more in depth later. One main concern of mine is that this will be a breaking change at...

Apologies for the delay and thank you for your patience. It's been hectic keeping up with support and general life. I wanna revisit this and see what can be done...