Jackie McDoniel

Results 231 comments of Jackie McDoniel

@andyslack the GitHub link is not working. Is this being maintained open source?

[As I said, if someone can get me a reproduction](https://github.com/nestjs/throttler/issues/1110#issuecomment-1292771629) I can better look into it. I haven't tried to look into rate limiting subscriptions as I don't use gql...

Yeah, this should most likely be pointed at the barrel file as you've set. We'll see when we can get this updated 👍

I actually ran into something similar building up [`nestjs-throttler`](https://github.com/jmcdo29/nestjs-throttler). I found a way around it though, using `context.getArgsByIndex(2)` to mimic `GqlExecutionContext.create(context).getContext()`. It does mean that Fastify is incompatible, but I...

@johnbiundo want me to take a look into fixing this? I think it's just a case of moving the `index.ts` into`src` and changing the `files` property of the `package.json` to...

Absolutely agree. Would you like to determine which ones should be removed and make a PR for it?

Interesting. This looks to be a side effect of commander. I checked with my `@ogma/cli` package which uses `commander` under the hood, and got the same immediate `help` output as...

Please provide a [minimum reproduction repository](https://minimum-reproduction.wtf/) (Git repository/[StackBlitz](https://stackblitz.com/fork/github/nestjs/typescript-starter)/[CodeSandbox](https://codesandbox.io/s/github/nestjs/typescript-starter/tree/master) project). ## [why reproductions are required](https://antfu.me/posts/why-reproductions-are-required)

Like any other nest application, nest will create the modules specified by the `AppModule`/`RootModule`. `nest-commander`'s `CommandFactory` is a wrapper around `NestFactory.createApplicationContext`. You can create a secondary `CliModule` that imports only...

What do you mean here by "based on the user inputs"? Inputs from the person running the CLI, or inputs from the dev? Technically, they're both possible, one just takes...