Jonathon Marolf

Results 110 comments of Jonathon Marolf

Yeah I don't really understand what problem we are trying to solve here. This sort of reminds me of [subtypes in ada](http://www.ada-auth.org/standards/rm12_w_tc1/html/RM-3-2-2.html) ```ada subtype Rainbow is Color range Red .....

In general, for File IO we believe that should be done in an MSBuild task. MSBuild has the mechanisms to correctly track file input, outputs, reads, and writes. Source generators...

> @jmarolf raised the question of whether it would make sense to introduce a TFM specifically for analyzers--basically netstandard2.0 minus the APIs we don't want you to use. The TFM...

see the docs [here](https://docs.microsoft.com/dotnet/core/tools/dotnet-format) for the full list of command names. I'm working this week on updating things in this repo to match

@CyrusNajmabadi I've refactored things further to move as much as possible off the UI thread. Was finding this hard to track so I moved all the logic that can happen...

@CyrusNajmabadi, have made a lot of changes. Updated the pr description to explain. This PR is now focusing on a _complete_ fix for performance vs. a tactical one.

@CyrusNajmabadi I am going to finish writing up the details in the markdown document I added, but I think everything else is ready for review if you have time.

Did a side-by-side of these changes with scrolling in a very large file https://user-images.githubusercontent.com/9797472/214719892-bd7c8e98-808a-4687-be59-787d9e9132f3.mp4

At @sharwell's request I've recorded several perf traces to verify that we are eliminating all the UI delays. ### Solution Open Delay This scenario loads Roslyn.sln with `src\Compilers\CSharp\Test\Semantic\Semantics\NullableReferenceTypesTests.cs` open. Without...

> > WPF will call our custom sort function and only sort data that is in view. > > Can you clarify this? That seems... wrong somehow. Say i have...