Jonathon Marolf

Results 110 comments of Jonathon Marolf

I think the answer to this question is "Yes" just so that its easier for us to debug customers build issues.

As we discussed in this comment thread https://github.com/dotnet/docs/pull/24896#discussion_r661102362 my position is we should have a `SkipGenerator` option that has an identical design to `SkipAnalyzers` from [here](https://github.com/dotnet/roslyn/blob/8c2dce8f7f30b33f18f8a58c3e4250f34f9ea9f3/src/Compilers/Core/MSBuildTask/Microsoft.Managed.Core.targets#L55). Generators are part of...

@jaredpar I agree that this is not as essential as /skipAnalyzers. essentially this is a diagnostic tool for us to use. I wish this was just an msbuild concept but...

I agree we should do (2) first and then wait for feedback / use cases to do (1)

> > @jmarolf Do we understand why the test platform APIs are so much slower? > > cc @nohwnd My understanding is that we can run discovery with xunit using...

@jaredpar would appreciate a review. unless there is anything blocking I would like to get this in and get the 3+ minutes back of CI time with other changes being...

can confirm this fixes running tests in visual studio: ![image](https://user-images.githubusercontent.com/9797472/194783188-933787a0-70a3-4c5d-be99-7b14b00cf7c4.png)

> @jmarolf Will we have updated packages on NuGet.org soon? We haven't release 1.1.2 yet the packages on nuget are 1.1.1 and should not have this issue are you observing...

> Looking at previous passing integration test runs and they seem to complete both `-test` and `-integrationTest` in

@svick looking at github we have: - [~17K](https://grep.app/search?q=_%20%3D%3E&filter[lang][0]=C%23) uses of `_ =>` - [~1K](https://grep.app/search?q=var%20_%20%3D&filter[lang][0]=C%23) uses of `var _ =` or `using var _ =` While I am only proposing removing...